From ff2fc39c379224c70135ad79eb3564d5621008e6 Mon Sep 17 00:00:00 2001
From: Pascal Sthamer <10992664+P4sca1@users.noreply.github.com>
Date: Fri, 25 Apr 2025 08:26:37 +0200
Subject: [PATCH] default backed update strategy to recreate

Signed-off-by: Pascal Sthamer <10992664+P4sca1@users.noreply.github.com>
---
 functions/kubernetes/charts/shuffle/README.md          | 2 +-
 functions/kubernetes/charts/shuffle/values.schema.json | 2 +-
 functions/kubernetes/charts/shuffle/values.yaml        | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/functions/kubernetes/charts/shuffle/README.md b/functions/kubernetes/charts/shuffle/README.md
index ff3885d1..45988a4c 100644
--- a/functions/kubernetes/charts/shuffle/README.md
+++ b/functions/kubernetes/charts/shuffle/README.md
@@ -217,7 +217,7 @@ The password should be provided with the `SHUFFLE_OPENSEARCH_PASSWORD` env varia
 | `backend.affinity`                                          | Affinity for backend pods assignment                                                                                                                                                                                               | `{}`                                         |
 | `backend.nodeSelector`                                      | Node labels for backend pods assignment                                                                                                                                                                                            | `{}`                                         |
 | `backend.tolerations`                                       | Tolerations for backend pods assignment                                                                                                                                                                                            | `[]`                                         |
-| `backend.updateStrategy.type`                               | backend deployment strategy type                                                                                                                                                                                                   | `RollingUpdate`                              |
+| `backend.updateStrategy.type`                               | backend deployment strategy type                                                                                                                                                                                                   | `Recreate`                                   |
 | `backend.priorityClassName`                                 | backend pods' priorityClassName                                                                                                                                                                                                    | `""`                                         |
 | `backend.topologySpreadConstraints`                         | Topology Spread Constraints for backend pod assignment spread across your cluster among failure-domains                                                                                                                            | `[]`                                         |
 | `backend.schedulerName`                                     | Name of the k8s scheduler (other than default) for backend pods                                                                                                                                                                    | `""`                                         |
diff --git a/functions/kubernetes/charts/shuffle/values.schema.json b/functions/kubernetes/charts/shuffle/values.schema.json
index b785b76e..529f484d 100644
--- a/functions/kubernetes/charts/shuffle/values.schema.json
+++ b/functions/kubernetes/charts/shuffle/values.schema.json
@@ -517,7 +517,7 @@
                         "type": {
                             "type": "string",
                             "description": "backend deployment strategy type",
-                            "default": "RollingUpdate"
+                            "default": "Recreate"
                         }
                     }
                 },
diff --git a/functions/kubernetes/charts/shuffle/values.yaml b/functions/kubernetes/charts/shuffle/values.yaml
index 507c2468..9723e96c 100644
--- a/functions/kubernetes/charts/shuffle/values.yaml
+++ b/functions/kubernetes/charts/shuffle/values.yaml
@@ -310,14 +310,14 @@ backend:
   ## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
   ##
   tolerations: []
-  ## ONLY FOR DEPLOYMENTS:
   ## @param backend.updateStrategy.type backend deployment strategy type
   ## ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy
   ##
   updateStrategy:
     ## Can be set to RollingUpdate or Recreate
+    ## Backend uses ReadWriteOnce volumes by default, which is incompatible with RollingUpdate
     ##
-    type: RollingUpdate
+    type: Recreate 
   ## @param backend.priorityClassName backend pods' priorityClassName
   ##
   priorityClassName: ""