marker/shuffle-cracked
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "fix: ignore duplicate action results during execution updates"

Browse Source 
This reverts commit fb4c1edb7b.
This commit is contained in:
yashsinghcodes
2026-05-01 13:14:51 +05:30
parent fb4c1edb7b
commit e4101f991a
1 changed files with 0 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/go-app/walkoff.go
-35
View File
@@ -593,15 +593,6 @@ func runWorkflowExecutionTransaction(ctx context.Context, attempts int64, workfl
return
}
if hasEquivalentActionResult(*workflowExecution, actionResult) {
log.Printf("[DEBUG][%s] Ignoring duplicate action result for action %s with status %s", workflowExecutionId, actionResult.Action.ID, actionResult.Status)
if resp != nil {
resp.WriteHeader(http.StatusOK)
resp.Write([]byte(`{"success": true, "reason": "duplicate result ignored"}`))
}
return
}
workflowExecution, dbSave, err := shuffle.ParsedExecutionResult(ctx, *workflowExecution, actionResult, false, 0)
if err != nil {
b, suberr := json.Marshal(actionResult)
@@ -637,32 +628,6 @@ func runWorkflowExecutionTransaction(ctx context.Context, attempts int64, workfl
}
func hasEquivalentActionResult(workflowExecution shuffle.WorkflowExecution, incoming shuffle.ActionResult) bool {
for _, existing := range workflowExecution.Results {
if existing.Action.ID != incoming.Action.ID {
continue
}
if existing.Status != incoming.Status {
continue
}
if existing.CompletedAt > 0 && incoming.CompletedAt > 0 && existing.CompletedAt == incoming.CompletedAt {
return true
}
if existing.StartedAt > 0 && incoming.StartedAt > 0 && existing.StartedAt == incoming.StartedAt {
return true
}
if len(existing.Result) > 0 && existing.Result == incoming.Result {
return true
}
}
return false
}
func JSONCheck(str string) bool {
var jsonStr interface{}
return json.Unmarshal([]byte(str), &jsonStr) == nil