From 074709c7bb6cccd8f570b6505a8d69d20a08db05 Mon Sep 17 00:00:00 2001
From: yashsinghcodes <yash9vardhan@gmail.com>
Date: Thu, 26 Jun 2025 20:02:50 +0530
Subject: [PATCH] fix orborus issues

---
 backend/go-app/walkoff.go           | 24 ++++++++++++++--------
 functions/onprem/orborus/orborus.go | 31 +++++++++++++++--------------
 2 files changed, 32 insertions(+), 23 deletions(-)

diff --git a/backend/go-app/walkoff.go b/backend/go-app/walkoff.go
index c194d091..0aff66c8 100755
--- a/backend/go-app/walkoff.go
+++ b/backend/go-app/walkoff.go
@@ -246,16 +246,16 @@ func handleGetWorkflowqueue(resp http.ResponseWriter, request *http.Request) {
 	}
 
 	// This is really the environment's name - NOT org-id
-	orgId := request.Header.Get("Org-Id")
-	if len(orgId) == 0 {
+	environment := request.Header.Get("Org-Id")
+	if len(environment) == 0 {
 		log.Printf("[AUDIT] No org-id header set")
 		resp.WriteHeader(401)
 		resp.Write([]byte(fmt.Sprintf(`{"success": false, "reason": "Specify the org-id header."}`)))
 		return
 	}
 
-	environment := request.Header.Get("org")
-	if len(environment) == 0 {
+	orgId := request.Header.Get("org")
+	if len(orgId) == 0 {
 		//log.Printf("[AUDIT] No 'org' header set (get workflow queue). ")
 		/*
 			resp.WriteHeader(403)
@@ -280,9 +280,17 @@ func handleGetWorkflowqueue(resp http.ResponseWriter, request *http.Request) {
 	//log.Printf("[AUDIT] Get workflow queue for org %s, env %s, orborus label %s", orgId, environment, orborusLabel)
 
 	ctx := shuffle.GetContext(request)
-	env, err := shuffle.GetEnvironment(ctx, orgId, "")
-	if err != nil {
-		log.Printf("[WARNING] No env found matching %s - continuing without updating orborus anyway: %s", orgId, err)
+	envs, err := shuffle.GetEnvironments(ctx, orgId)
+	if err != nil || len(envs) == 0 {
+		log.Printf("[WARNING] No env found matching %s - continuing without updating orborus anyway: %s", environment, err)
+	}
+
+	var env *shuffle.Environment
+	for _, e := range envs {
+		if e.Name == environment {
+			env = &e
+			break
+		}
 	}
 
 	timeNow := time.Now().Unix()
@@ -450,7 +458,7 @@ func handleGetWorkflowqueue(resp http.ResponseWriter, request *http.Request) {
 		}
 	}
 
-	executionRequests, err := shuffle.GetWorkflowQueue(ctx, orgId, 100)
+	executionRequests, err := shuffle.GetWorkflowQueue(ctx, environment, 100)
 	if err != nil {
 		// Skipping as this comes up over and over
 		//log.Printf("(2) Failed reading body for workflowqueue: %s", err)
diff --git a/functions/onprem/orborus/orborus.go b/functions/onprem/orborus/orborus.go
index 9b5c87da..e350082b 100755
--- a/functions/onprem/orborus/orborus.go
+++ b/functions/onprem/orborus/orborus.go
@@ -813,21 +813,21 @@ func handleBackendImageDownload(ctx context.Context, images string) error {
 		newImages = append(newImages, curimage)
 
 		// Force remove the current image to avoid cached layers
-		if swarmConfig == "run" || swarmConfig == "swarm" {
-			_, err := dockercli.ImageRemove(ctx, curimage, image.RemoveOptions{
-				Force:         true,
-				PruneChildren: true,
-			})
-
-			if err != nil {
-				log.Printf("[ERROR] Failed removing image for re-download: %s", err)
-			} else {
-				log.Printf("[DEBUG] Removed image: %s", curimage)
-			}
-		} else {
-			//log.Printf("[DEBUG] Skipping image removal for %s as swarmConfig is not set to run or swarm. Value: %#v", curimage, swarmConfig)
-		}
-
+//		if swarmConfig == "run" || swarmConfig == "swarm" {
+//			_, err := dockercli.ImageRemove(ctx, curimage, image.RemoveOptions{
+//				Force:         true,
+//				PruneChildren: true,
+//			})
+//
+//			if err != nil {
+//				log.Printf("[ERROR] Failed removing image for re-download: %s", err)
+//			} else {
+//				log.Printf("[DEBUG] Removed image: %s", curimage)
+//			}
+//		} else {
+//			//log.Printf("[DEBUG] Skipping image removal for %s as swarmConfig is not set to run or swarm. Value: %#v", curimage, swarmConfig)
+//		}
+//
 		err := shuffle.DownloadDockerImageBackend(&http.Client{Timeout: imagedownloadTimeout}, curimage)
 		if err != nil {
 			//log.Printf("[ERROR] Failed downloading image: %s", err)
@@ -874,6 +874,7 @@ func handleBackendImageDownload(ctx context.Context, images string) error {
 					// Update the service to run with the new image
 					//docker service update --image username/imagename:latest servicename --force
 					serviceUpdateOptions := types.ServiceUpdateOptions{}
+					service.Spec.TaskTemplate.ForceUpdate++
 					resp, err := dockercli.ServiceUpdate(
 						ctx,
 						service.ID,