#74: This was a frontend bug. Overwrites existing workflows

This commit is contained in:
frikky
2020-06-25 15:35:33 +02:00
parent c20df3c850
commit 8e5af32f21
2 changed files with 16 additions and 16 deletions
+7 -6
View File
@@ -850,6 +850,7 @@ const AngularWorkflow = (props) => {
const onEdgeAdded = (event) => { const onEdgeAdded = (event) => {
setLastSaved(false) setLastSaved(false)
const edge = event.target.data() const edge = event.target.data()
console.log(workflow.branches)
// Check if: // Check if:
// dest == source && source == dest // dest == source && source == dest
@@ -863,7 +864,7 @@ const AngularWorkflow = (props) => {
found = true found = true
break break
} else if (workflow.branches[key].destination_id === edge.target && workflow.branches[key].source_id === edge.source) { } else if (workflow.branches[key].destination_id === edge.target && workflow.branches[key].source_id === edge.source) {
console.log(edge) console.log(edge.source)
alert.error("That branch already exists") alert.error("That branch already exists")
event.target.remove() event.target.remove()
found = true found = true
@@ -1333,9 +1334,9 @@ const AngularWorkflow = (props) => {
}) })
.then((responseJson) => { .then((responseJson) => {
if (!responseJson.success) { if (!responseJson.success) {
alert.error("Failed to delete schedule: " + responseJson.reason) //alert.error("Failed to delete schedule: " + responseJson.reason)
} else { } else {
alert.success("Successfully stopped schedule") //alert.success("Successfully stopped schedule")
workflow.triggers[triggerindex].status = "stopped" workflow.triggers[triggerindex].status = "stopped"
trigger.status = "stopped" trigger.status = "stopped"
setSelectedTrigger(trigger) setSelectedTrigger(trigger)
@@ -1807,7 +1808,7 @@ const AngularWorkflow = (props) => {
} }
if (data.is_valid === false) { if (data.is_valid === false) {
alert.error("Sorry, "+data.name+" is not ready yet") alert.error(data.name+" is only available on https://shuffler.io")
return return
} }
@@ -1881,7 +1882,7 @@ const AngularWorkflow = (props) => {
} }
if (data.name !== "User Input") { if (data.name !== "User Input") {
workflow.branches.push(newbranch) //workflow.branches.push(newbranch)
cy.add(edgeToBeAdded) cy.add(edgeToBeAdded)
} }
@@ -4022,7 +4023,7 @@ const AngularWorkflow = (props) => {
}) })
.then((responseJson) => { .then((responseJson) => {
if (responseJson.success) { if (responseJson.success) {
alert.success("Successfully stopped webhook") //alert.success("Successfully stopped webhook")
// Set the status // Set the status
workflow.triggers[triggerindex].status = "stopped" workflow.triggers[triggerindex].status = "stopped"
trigger.status = "stopped" trigger.status = "stopped"
+9 -10
View File
@@ -89,7 +89,6 @@ const Workflows = (props) => {
return response.json() return response.json()
}) })
.then((responseJson) => { .then((responseJson) => {
console.log(responseJson)
setSelectedExecution({}) setSelectedExecution({})
setWorkflowExecutions([]) setWorkflowExecutions([])
@@ -807,7 +806,7 @@ const Workflows = (props) => {
const ret = setNewWorkflow(data.name, data.description, data, false) const ret = setNewWorkflow(data.name, data.description, data, false)
.then((response) => { .then((response) => {
if (response !== undefined) { if (response !== undefined) {
alert.success("Successfully created "+data.name) alert.success("Successfully imported "+data.name)
} }
}) })
} }
@@ -1031,20 +1030,20 @@ const Workflows = (props) => {
}) })
.then((response) => { .then((response) => {
if (response.status === 200) { if (response.status === 200) {
response.text().then(function (text) { alert.success("Successfully loaded workflows from "+downloadUrl)
console.log("RETURN: ", text) getAvailableWorkflows()
alert.success("Loaded existing apps!")
})
} }
return response.json() return response.json()
}) })
.then((responseJson) => { .then((responseJson) => {
console.log("DATA: ", responseJson) console.log("DATA: ", responseJson)
if (responseJson.reason !== undefined) { if (!responseJson.success) {
alert.error("Failed loading: "+responseJson.reason) if (responseJson.reason !== undefined) {
} else { alert.error("Failed loading: "+responseJson.reason)
alert.error("Failed loading") } else {
alert.error("Failed loading")
}
} }
}) })
.catch(error => { .catch(error => {