From 392e78208449f02c53a4d503e5949ac837509937 Mon Sep 17 00:00:00 2001
From: Aditya <60684641+0x0elliot@users.noreply.github.com>
Date: Mon, 6 Apr 2026 13:46:56 +0530
Subject: [PATCH] fix: making disableRule and enableRule safer

---
 functions/onprem/orborus/orborus.go | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/functions/onprem/orborus/orborus.go b/functions/onprem/orborus/orborus.go
index 99639e72..0ef9dc88 100755
--- a/functions/onprem/orborus/orborus.go
+++ b/functions/onprem/orborus/orborus.go
@@ -4009,7 +4009,8 @@ func removeFile(fileName string) error {
 }
 
 func removePath(containerName, path string) error {
-	rmCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("rm -rf %s", path))
+	// rmCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("rm -rf %s", path))
+	rmCmd := exec.Command("docker", "exec", "-u", "root", containerName, "rm", "-rf", path)
 	output, err := rmCmd.CombinedOutput()
 	if err != nil {
 		return fmt.Errorf("error removing path: %v, output: %s", err, output)
@@ -4068,7 +4069,8 @@ func disableRule(fileName string) error {
 	destDir := "/var/lib/tenzir/disabled_rules"
 	destPath := fmt.Sprintf("%s/%s", destDir, fileName)
 
-	checkSrcCmd := exec.Command("docker", "exec", containerName, "sh", "-c", fmt.Sprintf("test -f %s", srcPath))
+	// checkSrcCmd := exec.Command("docker", "exec", containerName, "sh", "-c", fmt.Sprintf("test -f %s", srcPath))
+	checkSrcCmd := exec.Command("docker", "exec", containerName, "test", "-f", srcPath)
 	if err := checkSrcCmd.Run(); err != nil {
 		if exitErr, ok := err.(*exec.ExitError); ok && exitErr.ExitCode() == 1 {
 			fmt.Printf("File does not exist: %s\n", srcPath)
@@ -4077,12 +4079,14 @@ func disableRule(fileName string) error {
 		return fmt.Errorf("error checking source file: %v", err)
 	}
 
-	checkDestDirCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mkdir -p %s", destDir))
+	// checkDestDirCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mkdir -p %s", destDir))
+	checkDestDirCmd := exec.Command("docker", "exec", "-u", "root", containerName, "mkdir", "-p", destDir)
 	if err := checkDestDirCmd.Run(); err != nil {
 		return fmt.Errorf("error ensuring destination directory exists: %v", err)
 	}
 
-	moveCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mv %s %s", srcPath, destPath))
+	// moveCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mv %s %s", srcPath, destPath))
+	moveCmd := exec.Command("docker", "exec", "-u", "root", containerName, "mv", srcPath, destPath)
 	if err := moveCmd.Run(); err != nil {
 		return fmt.Errorf("error moving file: %v", err)
 	}
@@ -4097,7 +4101,8 @@ func enableRule(fileName string) error {
 	destDir := "/var/lib/tenzir/sigma_rules"
 	destPath := fmt.Sprintf("%s/%s", destDir, fileName)
 
-	checkSrcCmd := exec.Command("docker", "exec", containerName, "sh", "-c", fmt.Sprintf("test -f %s", srcPath))
+	// checkSrcCmd := exec.Command("docker", "exec", containerName, "sh", "-c", fmt.Sprintf("test -f %s", srcPath))
+	checkSrcCmd := exec.Command("docker", "exec", containerName, "test", "-f", srcPath)
 	if err := checkSrcCmd.Run(); err != nil {
 		if exitErr, ok := err.(*exec.ExitError); ok && exitErr.ExitCode() == 1 {
 			fmt.Printf("File does not exist: %s\n", srcPath)
@@ -4106,11 +4111,13 @@ func enableRule(fileName string) error {
 		return fmt.Errorf("error checking source file: %v", err)
 	}
 
-	checkDestDirCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mkdir -p %s", destDir))
+	// checkDestDirCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mkdir -p %s", destDir))
+	checkDestDirCmd := exec.Command("docker", "exec", "-u", "root", containerName, "mkdir", "-p", destDir)
 	if err := checkDestDirCmd.Run(); err != nil {
 		return fmt.Errorf("error ensuring destination directory exists: %v", err)
 	}
-	moveCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mv %s %s", srcPath, destPath))
+	// moveCmd := exec.Command("docker", "exec", "-u", "root", containerName, "sh", "-c", fmt.Sprintf("mv %s %s", srcPath, destPath))
+	moveCmd := exec.Command("docker", "exec", "-u", "root", containerName, "mv", srcPath, destPath)
 	if err := moveCmd.Run(); err != nil {
 		return fmt.Errorf("error moving file: %v", err)
 	}