c43e7c4c9b
Критические фиксы: - main.py: монтировать /static из web/static/ (CSS не грузился совсем) - api/scans.py: filtered total count (был всегда общий, игнорируя фильтры) - web/routes.py: исправлен VALID_SORT_FIELDS (отсутствовали ключи packages) - web/routes.py: filtered total count для web scans list - package_detail.html: f.data.X вместо f.X (findings не отображались) Чистка мёртвого кода: - config.py: удалён _parse_repos и nexus_repositories (не использовались) - web/routes.py: удалён completed_scans/failed_scans (не отображались) - удалён мёртвый guarddog_nexus/static/style.css (67-байтный стаб) Качество кода: - web/routes.py: Jinja2 Environment кэшируется на уровне модуля - Вынесен дублирующийся JS в web/static/app.js - Вынесены дублирующиеся inline-стили в CSS-классы - Исправлен duplicate class attribute в списках - Удалены гигантские SVG из empty states Тесты: - 20 новых edge-case тестов (CSV export, search/filter/sort, 404, pagination) - Добавлен sample_flagged_scan fixture - Итого: 50 тестов, все зелёные
248 lines
7.0 KiB
Python
248 lines
7.0 KiB
Python
"""Tests for REST API endpoints."""
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_health(client):
|
|
resp = await client.get("/health")
|
|
assert resp.status_code == 200
|
|
assert resp.json()["status"] == "ok"
|
|
|
|
|
|
# --- Scans ---
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_scans_empty(client):
|
|
resp = await client.get("/api/v1/scans")
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["total"] == 0
|
|
assert len(data["scans"]) == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_scan_stats_empty(client):
|
|
resp = await client.get("/api/v1/scans/stats")
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["total_scans"] == 0
|
|
assert data["flagged_scans"] == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_scan_not_found(client):
|
|
resp = await client.get("/api/v1/scans/99999")
|
|
assert resp.status_code == 200
|
|
assert "detail" in resp.json()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_scans_with_filters(client):
|
|
# Filter parameters smoke test — should not 500
|
|
for params in [
|
|
"?flagged=true&search=test&status=completed&sort_by=id&sort_dir=asc",
|
|
"?flagged=false&search=nonexistent&sort_by=total_findings",
|
|
"?sort_by=invalid_key",
|
|
"?limit=10&offset=0",
|
|
]:
|
|
resp = await client.get(f"/api/v1/scans{params}")
|
|
assert resp.status_code == 200, f"Failed on: {params}"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_scan_stats_with_data(client, sample_flagged_scan):
|
|
resp = await client.get("/api/v1/scans/stats")
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["total_scans"] == 1
|
|
assert data["flagged_scans"] == 1
|
|
assert data["total_findings"] == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_scans_csv_export_empty(client):
|
|
resp = await client.get("/api/v1/scans/export")
|
|
assert resp.status_code == 200
|
|
assert "text/csv" in resp.headers["content-type"]
|
|
assert "id,package_name" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_scans_csv_export_with_filter(client, sample_flagged_scan):
|
|
resp = await client.get("/api/v1/scans/export?flagged=true")
|
|
assert resp.status_code == 200
|
|
assert sample_flagged_scan.package_name in resp.text
|
|
|
|
|
|
# --- Packages ---
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_packages_empty(client):
|
|
resp = await client.get("/api/v1/packages")
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["total"] == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_packages_with_filters(client):
|
|
for params in [
|
|
"?search=test&sort_by=name&sort_dir=asc",
|
|
"?flagged=false&sort_by=last_scanned_at",
|
|
"?ecosystem=pypi",
|
|
"?sort_by=invalid",
|
|
]:
|
|
resp = await client.get(f"/api/v1/packages{params}")
|
|
assert resp.status_code == 200, f"Failed on: {params}"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_packages_csv_export_empty(client):
|
|
resp = await client.get("/api/v1/packages/export")
|
|
assert resp.status_code == 200
|
|
assert "text/csv" in resp.headers["content-type"]
|
|
assert "name,version" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_packages_csv_export_with_filter(client, sample_flagged_scan):
|
|
resp = await client.get("/api/v1/packages/export?flagged=true")
|
|
assert resp.status_code == 200
|
|
assert sample_flagged_scan.package_name in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_package_with_data(client, sample_flagged_scan):
|
|
resp = await client.get(
|
|
f"/api/v1/packages/{sample_flagged_scan.package_name}/{sample_flagged_scan.package_version}"
|
|
)
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["name"] == sample_flagged_scan.package_name
|
|
assert len(data["scans"]) == 1
|
|
assert data["flagged"] is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_package_not_found(client):
|
|
resp = await client.get("/api/v1/packages/nonexistent/1.0")
|
|
assert resp.status_code == 200
|
|
assert "detail" in resp.json()
|
|
|
|
|
|
# --- Findings ---
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_findings_empty(client):
|
|
resp = await client.get("/api/v1/findings")
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["total"] == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_findings_with_data(client, sample_flagged_scan):
|
|
resp = await client.get("/api/v1/findings")
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["total"] == 1
|
|
assert len(data["findings"]) == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_findings_with_filters(client, sample_flagged_scan):
|
|
for params in [
|
|
f"?scan_id={sample_flagged_scan.id}",
|
|
"?severity=WARNING",
|
|
"?rule=test_rule",
|
|
]:
|
|
resp = await client.get(f"/api/v1/findings{params}")
|
|
assert resp.status_code == 200, f"Failed on: {params}"
|
|
|
|
|
|
# --- Web UI ---
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_dashboard(client):
|
|
resp = await client.get("/")
|
|
assert resp.status_code == 200
|
|
assert "GuardDog Nexus" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_dashboard_stats_fragment(client):
|
|
resp = await client.get("/dashboard/stats")
|
|
assert resp.status_code == 200
|
|
assert "Total Scans" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_scans(client):
|
|
resp = await client.get("/scans")
|
|
assert resp.status_code == 200
|
|
assert "Scans" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_scans_with_search(client):
|
|
resp = await client.get("/scans?search=nonexistent&status=completed&sort_by=id&sort_dir=asc")
|
|
assert resp.status_code == 200
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_scans_page_out_of_range(client):
|
|
resp = await client.get("/scans?page=999")
|
|
assert resp.status_code == 200
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_scan_not_found(client):
|
|
resp = await client.get("/scans/99999")
|
|
assert resp.status_code == 404
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_scan_detail(client, sample_flagged_scan):
|
|
resp = await client.get(f"/scans/{sample_flagged_scan.id}")
|
|
assert resp.status_code == 200
|
|
assert sample_flagged_scan.package_name in resp.text
|
|
assert "test_rule" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_packages(client):
|
|
resp = await client.get("/packages")
|
|
assert resp.status_code == 200
|
|
assert "Packages" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_packages_with_search(client):
|
|
resp = await client.get("/packages?search=test&sort_by=name&sort_dir=asc")
|
|
assert resp.status_code == 200
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_package_not_found(client):
|
|
resp = await client.get("/packages/nonexistent/1.0")
|
|
assert resp.status_code == 404
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_web_ui_package_detail(client, sample_flagged_scan):
|
|
resp = await client.get(
|
|
f"/packages/{sample_flagged_scan.package_name}/{sample_flagged_scan.package_version}"
|
|
)
|
|
assert resp.status_code == 200
|
|
assert sample_flagged_scan.package_name in resp.text
|
|
assert "test_rule" in resp.text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_health_no_db_leak(client):
|
|
# Rapid health checks should not exhaust connections
|
|
for _ in range(5):
|
|
resp = await client.get("/health")
|
|
assert resp.status_code == 200
|