Files
guarddog-nexus/guarddog_nexus/web/templates/dashboard_stats.html
Marker689 c43e7c4c9b fix: критические баги и качество кода — полный аудит
Критические фиксы:
- main.py: монтировать /static из web/static/ (CSS не грузился совсем)
- api/scans.py: filtered total count (был всегда общий, игнорируя фильтры)
- web/routes.py: исправлен VALID_SORT_FIELDS (отсутствовали ключи packages)
- web/routes.py: filtered total count для web scans list
- package_detail.html: f.data.X вместо f.X (findings не отображались)

Чистка мёртвого кода:
- config.py: удалён _parse_repos и nexus_repositories (не использовались)
- web/routes.py: удалён completed_scans/failed_scans (не отображались)
- удалён мёртвый guarddog_nexus/static/style.css (67-байтный стаб)

Качество кода:
- web/routes.py: Jinja2 Environment кэшируется на уровне модуля
- Вынесен дублирующийся JS в web/static/app.js
- Вынесены дублирующиеся inline-стили в CSS-классы
- Исправлен duplicate class attribute в списках
- Удалены гигантские SVG из empty states

Тесты:
- 20 новых edge-case тестов (CSV export, search/filter/sort, 404, pagination)
- Добавлен sample_flagged_scan fixture
- Итого: 50 тестов, все зелёные
2026-05-10 03:46:05 +03:00

151 lines
5.3 KiB
HTML

<div class="stats-grid">
<article class="stat-card">
<h3>{{ total_scans }}</h3>
<small>Total Scans</small>
</article>
<article class="stat-card">
<h3 class="flagged">{{ flagged_scans }}</h3>
<small>⚠ Flagged</small>
</article>
<article class="stat-card">
<h3>{{ recent_flagged }}</h3>
<small>Flagged (7 days)</small>
</article>
<article class="stat-card">
<h3>{{ total_findings }}</h3>
<small>Total Findings</small>
</article>
<article class="stat-card">
<h3 class="severity-ERROR">{{ errors_count }}</h3>
<small>Errors</small>
</article>
<article class="stat-card">
<h3 class="severity-WARNING">{{ warnings_count }}</h3>
<small>Warnings</small>
</article>
</div>
{% if total_findings > 0 %}
<div>
<small>Severity ratio</small>
<div class="severity-bar">
{% set err_pct = (errors_count / total_findings * 100) | int %}
{% set warn_pct = 100 - err_pct %}
<div class="bar-error" style="width: {{ err_pct }}%;" title="ERROR: {{ errors_count }}"></div>
<div class="bar-warning" style="width: {{ warn_pct }}%;" title="WARNING: {{ warnings_count }}"></div>
</div>
<div class="severity-bar-labels">
<span class="severity-ERROR">ERROR {{ errors_count }}</span>
<span class="severity-WARNING">WARNING {{ warnings_count }}</span>
</div>
</div>
{% else %}
<p class="empty-state">No findings yet — scan results will appear here once packages are processed.</p>
{% endif %}
{% if days %}
<div>
<small>Scan activity (14 days)</small>
<div class="heatmap">
{% set max_cnt = days | map(attribute=1) | max %}
{% for day, cnt, fl in days %}
<div class="heatmap-day" title="{{ day }}: {{ cnt }} scans, {{ fl }} flagged">
{% set h = (cnt / max_cnt * 38) | int if max_cnt > 0 else 0 %}
<div class="bar" style="height: {{ h }}px; background: {% if fl > 0 %}var(--pico-color-red-500){% else %}var(--pico-color-zinc-500){% endif %};"></div>
<div class="tooltip">{{ day }}: {{ cnt }} scans, {{ fl }} flagged</div>
</div>
{% endfor %}
</div>
</div>
{% endif %}
{% if most_flagged %}
<div>
<h3>⚠ Most Flagged Packages</h3>
<table>
<thead>
<tr><th>Package</th><th>Version</th><th>Findings</th></tr>
</thead>
<tbody>
{% for p in most_flagged %}
<tr>
<td><a href="/packages/{{ p.package_name }}/{{ p.package_version }}"><strong>{{ p.package_name }}</strong></a></td>
<td>{{ p.package_version }}</td>
<td>
<span class="flagged">{{ p.total }}</span>
<progress value="{{ p.total }}" max="{{ max_findings }}" style="width: 80px; height: 6px; vertical-align: middle; margin-left: 6px;"></progress>
</td>
</tr>
{% endfor %}
</tbody>
</table>
</div>
{% endif %}
{% if latest_flagged %}
<div>
<h3>🔴 Latest Flagged</h3>
<table>
<thead>
<tr><th>Package</th><th>Version</th><th>Findings</th><th>Time</th></tr>
</thead>
<tbody>
{% for s in latest_flagged %}
<tr>
<td><a href="/scans/{{ s.id }}"><strong class="flagged">{{ s.package_name }}</strong></a></td>
<td>{{ s.package_version }}</td>
<td><span class="flagged">{{ s.total_findings }}</span></td>
<td>{{ s.started_at.strftime('%m-%d %H:%M') if s.started_at }}</td>
</tr>
{% endfor %}
</tbody>
</table>
</div>
{% endif %}
<h3>Latest Scans</h3>
<table>
<thead>
<tr>
<th>Package</th>
<th>Version</th>
<th>Repo</th>
<th>Status</th>
<th></th>
<th>Time</th>
</tr>
</thead>
<tbody>
{% for s in latest_scans %}
<tr>
<td><a href="/packages/{{ s.package_name }}/{{ s.package_version }}">{{ s.package_name }}</a></td>
<td>{{ s.package_version }}</td>
<td><small>{{ s.repository }}</small></td>
<td>
{% if s.status == 'scanning' %}<span class="status-scanning"><span class="spinner"></span>scanning</span>{% else %}<span class="status-{{ s.status }}">{{ s.status }}</span>{% endif %}
</td>
<td>{% if s.flagged %}<span class="flagged">⚠ {{ s.total_findings }}</span>{% elif s.status == 'completed' %}<span class="clean"></span>{% else %}<span>-</span>{% endif %}</td>
<td>{{ s.started_at.strftime('%m-%d %H:%M') if s.started_at }}</td>
</tr>
{% endfor %}
</tbody>
</table>
<small><a href="/scans">View all scans →</a></small>
{% if top_rules %}
<div class="top-rules-chart">
<h3>Top Rules Triggered</h3>
{% for rule, cnt in top_rules %}
<div class="rule-bar-row">
<span class="rule-name" title="{{ rule }}"><code>{{ rule }}</code></span>
<div class="rule-bar-container">
<div class="rule-bar" style="width: {{ (cnt / top_rules[0][1] * 100) | int if top_rules[0][1] > 0 else 0 }}%;"></div>
</div>
<span class="rule-count">{{ cnt }}</span>
</div>
{% endfor %}
</div>
{% endif %}
<small style="opacity: 0.5;">Last refresh: {{ now.strftime('%H:%M:%S') }} (auto every 30s)</small>