fix: аудит — 19 фиксов безопасности, надёжности, UI и 16 новых тестов
- S4: bump jinja2>=3.1.4, python-multipart>=0.0.18, httpx>=0.28.0
- S5: _detect_ecosystem — DEFAULT_ECOSYSTEM для неизвестных форматов
- S6: harvester — log.exception() вместо log.error()
- S8: _scan_component — urlencode параметров
- P1: scanner — proc.kill() при таймауте
- P3: api_packages — selectinload(Scan.findings), убран N+1
- P4+P5: утечка _url_locks и _llm_locks при early return
- P6: DB reaper — сброс {'status':'analyzing'} при старте
- UI: htmx-пагинация, фильтры не теряют flagged, 404 с layout
- UI: мобильные таблицы overflow-x, полная стата на дашборде
- UI: i18n статусов в _status_badge, urlencode package_name
- 16 новых тестов: analyze endpoint (6), scanner errors (4),
webhook signature (2), llm client (4)
This commit is contained in:
@@ -1,6 +1,11 @@
|
||||
"""Tests for GuardDog scanner integration."""
|
||||
|
||||
from guarddog_nexus.core.scanner import _normalize_output
|
||||
import asyncio
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
from guarddog_nexus.core.scanner import _normalize_output, scan_package
|
||||
|
||||
|
||||
def test_normalize_clean_output(guarddog_output_clean):
|
||||
@@ -49,3 +54,47 @@ def test_normalize_semgrep_list():
|
||||
assert len(result["findings"]) == 2
|
||||
assert result["findings"][0]["location"] == "setup.py:10"
|
||||
assert result["findings"][0]["severity"] == "ERROR"
|
||||
|
||||
|
||||
# --- scan_package() error paths ---
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_scan_package_timeout():
|
||||
with patch("asyncio.wait_for", side_effect=asyncio.TimeoutError):
|
||||
result = await scan_package("/tmp/test.tar.gz", "pypi")
|
||||
assert result["findings"] == []
|
||||
assert "timeout" in result["errors"][0]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_scan_package_binary_not_found():
|
||||
with patch("asyncio.create_subprocess_exec", side_effect=FileNotFoundError):
|
||||
result = await scan_package("/tmp/test.tar.gz", "pypi")
|
||||
assert result["findings"] == []
|
||||
assert "not_found" in result["errors"][0]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_scan_package_invalid_json():
|
||||
mock_proc = MagicMock()
|
||||
mock_proc.returncode = 0
|
||||
mock_proc.communicate.return_value = (b"not valid json", b"")
|
||||
|
||||
with patch("asyncio.create_subprocess_exec", return_value=mock_proc):
|
||||
with patch("asyncio.wait_for", return_value=(b"not valid json", b"")):
|
||||
result = await scan_package("/tmp/test.tar.gz", "pypi")
|
||||
assert result["findings"] == []
|
||||
assert "json" in result["errors"][0]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_scan_package_non_zero_exit():
|
||||
mock_proc = MagicMock()
|
||||
mock_proc.returncode = 2
|
||||
|
||||
with patch("asyncio.create_subprocess_exec", return_value=mock_proc):
|
||||
with patch("asyncio.wait_for", return_value=(b"{}", b"guarddog: corrupted")):
|
||||
result = await scan_package("/tmp/test.tar.gz", "pypi")
|
||||
assert result["findings"] == []
|
||||
assert "guarddog" in result["errors"][0]
|
||||
|
||||
Reference in New Issue
Block a user